]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/dp_mst: Fix drm_dp_send_dpcd_write() return code
authorLyude Paul <lyude@redhat.com>
Fri, 24 Apr 2020 19:07:22 +0000 (15:07 -0400)
committerLyude Paul <lyude@redhat.com>
Mon, 27 Apr 2020 16:50:18 +0000 (12:50 -0400)
commitdbc05ae3867628abce5619bfab868a43818bdb0d
tree375deb3ceac9799a5d30133d755bb7df1238ae87
parenta5bff92eaac45bdf6221badf9505c26792fdf99e
drm/dp_mst: Fix drm_dp_send_dpcd_write() return code

drm_dp_mst_wait_tx_reply() returns > 1 if time elapsed in
wait_event_timeout() before check_txmsg_state(mgr, txmsg) evaluated to
true. However, we make the mistake of returning this time from
drm_dp_send_dpcd_write() on success instead of returning the number of
bytes written - causing spontaneous failures during link probing:

[drm:drm_dp_send_link_address [drm_kms_helper]] *ERROR* GUID check on
10:01 failed: 3975

Yikes! So, fix this by returning the number of bytes written on success
instead.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Fixes: cb897542c6d2 ("drm/dp_mst: Fix W=1 warnings")
Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
Cc: Sean Paul <sean@poorly.run>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Sean Paul <sean@poorly.run>
Link: https://patchwork.freedesktop.org/patch/msgid/20200424190722.775284-1-lyude@redhat.com
drivers/gpu/drm/drm_dp_mst_topology.c