]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
PCI: j721e: Fix j721e_pcie_probe() error path
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 27 Jun 2021 11:46:24 +0000 (13:46 +0200)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 7 Dec 2021 06:33:34 +0000 (07:33 +0100)
commitdbda1ee5b3a12d6b7ac2cc93eb7fd9a59dbd945c
tree2f395c9d14028bf0e457f9b70b4d09bee2ce891a
parent625e435c5912dd72dafded0d78a7cf8d2467cfb5
PCI: j721e: Fix j721e_pcie_probe() error path

BugLink: https://bugs.launchpad.net/bugs/1951822
[ Upstream commit 496bb18483cc0474913e81e18a6b313aaea4c120 ]

If an error occurs after a successful cdns_pcie_init_phy() call, it must be
undone by a cdns_pcie_disable_phy() call, as already done above and below.

Update the goto to branch at the correct place of the error handling path.

Link: https://lore.kernel.org/r/db477b0cb444891a17c4bb424467667dc30d0bab.1624794264.git.christophe.jaillet@wanadoo.fr
Fixes: 49e0efdce791 ("PCI: j721e: Add support to provide refclk to PCIe connector")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Krzysztof WilczyƄski <kw@linux.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/pci/controller/cadence/pci-j721e.c