]> git.proxmox.com Git - mirror_qemu.git/commit
hw/display/virtio-gpu: Fix memory leak (CID 1453811)
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Mon, 31 May 2021 10:19:28 +0000 (12:19 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Thu, 22 Jul 2021 11:31:51 +0000 (13:31 +0200)
commitdc2deaba4852e3324a4558a8bd29c58ce3299699
tree1621159c9d32c4946d6e75bbae77be331af65872
parente77c8b8b8e933414ef07dbed04e02973fccffeb0
hw/display/virtio-gpu: Fix memory leak (CID 1453811)

To avoid leaking memory on the error path, reorder the
code as:
- check the parameters first
- check resource already existing
- finally allocate memory

Reported-by: Coverity (CID 1453811: RESOURCE_LEAK)
Fixes: e0933d91b1c ("virtio-gpu: Add virtio_gpu_resource_create_blob")
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210531101928.1662732-1-philmd@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
hw/display/virtio-gpu.c