]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
bpf: avoid -Wmaybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Fri, 25 May 2018 21:33:20 +0000 (23:33 +0200)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 28 May 2018 15:40:59 +0000 (17:40 +0200)
commitdc3b8ae9d271897e09b27fa4e4e0000de98590d1
treed801db41bd5c8ced70e67a853d85e09022a75bb6
parent53c8036cb715f3577a7fe1db6e6ad06e8697b36f
bpf: avoid -Wmaybe-uninitialized warning

The stack_map_get_build_id_offset() function is too long for gcc to track
whether 'work' may or may not be initialized at the end of it, leading
to a false-positive warning:

kernel/bpf/stackmap.c: In function 'stack_map_get_build_id_offset':
kernel/bpf/stackmap.c:334:13: error: 'work' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This removes the 'in_nmi_ctx' flag and uses the state of that variable
itself to see if it got initialized.

Fixes: bae77c5eb5b2 ("bpf: enable stackmap with build_id in nmi context")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
kernel/bpf/stackmap.c