]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
mm: fs: fix lru_cache_disabled race in bh_lru
authorMinchan Kim <minchan@kernel.org>
Tue, 22 Mar 2022 21:39:34 +0000 (14:39 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 12:37:31 +0000 (14:37 +0200)
commitdc3cc6156e1d0e9ff9cf12ae07acb34d327b54ab
treeec37a0a6c01d5376f71f243d4e4e956d144d9b77
parentaa3d558af282a7abe7f316964b140877c4f83552
mm: fs: fix lru_cache_disabled race in bh_lru

BugLink: https://bugs.launchpad.net/bugs/1969110
commit c0226eb8bde854e016a594a16f5c0d98aca426fa upstream.

Check lru_cache_disabled under bh_lru_lock.  Otherwise, it could introduce
race below and it fails to migrate pages containing buffer_head.

   CPU 0 CPU 1

bh_lru_install
                                       lru_cache_disable
  lru_cache_disabled = false
                                       atomic_inc(&lru_disable_count);
       invalidate_bh_lrus_cpu of CPU 0
       bh_lru_lock
       __invalidate_bh_lrus
       bh_lru_unlock
  bh_lru_lock
  install the bh
  bh_lru_unlock

WHen this race happens a CMA allocation fails, which is critical for
the workload which depends on CMA.

Link: https://lkml.kernel.org/r/20220308180709.2017638-1-minchan@kernel.org
Fixes: 8cc621d2f45d ("mm: fs: invalidate BH LRU during page migration")
Signed-off-by: Minchan Kim <minchan@kernel.org>
Cc: Chris Goldsworthy <cgoldswo@codeaurora.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: John Dias <joaodias@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit ab657a29c3e9f02a7c7ca9ddaa7b176dec04f86e)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
fs/buffer.c