]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
scsi: qla2xxx: Spinlock recursion in qla_target
authorMikhail Malygin <m.malygin@yadro.com>
Wed, 13 Jun 2018 13:05:57 +0000 (13:05 +0000)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 14 Jan 2019 09:28:55 +0000 (09:28 +0000)
commitdc5d0db75cb6b782a8c03fef5136060dc698603b
tree9b9f9147f14c14b56cb8b3c430d5a97074c06c0c
parent13387a8c05a86dee55e49d71f917d4b24600ee08
scsi: qla2xxx: Spinlock recursion in qla_target

BugLink: http://bugs.launchpad.net/bugs/1807469
commit 49d7bd36813ea8e6b4c97b640d24e7fbd44c84f0 upstream.

The patch reverts changes done in qlt_schedule_sess_for_deletion() to
avoid spinlock recursion sess->vha->work_lock should be used instead
of ha->tgt.sess_lock, that can be locked in callers: qlt_reset() or
qlt_handle_login()

[mkp: roll in build warning reported by sfr]

Fixes: 1c6cacf4ea6c04 ("scsi: qla2xxx: Fixup locking for session deletion")
Cc: <stable@vger.kernel.org> #v4.17
Signed-off-by: Mikhail Malygin <m.malygin@yadro.com>
Reported-by: Mikhail Malygin <m.malygin@yadro.com>
Tested-by: Mikhail Malygin <m.malygin@yadro.com>
Acked-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/scsi/qla2xxx/qla_target.c