]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
NFS/sunrpc: don't use a credential with extra groups.
authorNeilBrown <neilb@suse.de>
Mon, 24 Oct 2011 23:25:49 +0000 (10:25 +1100)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Tue, 25 Oct 2011 09:20:58 +0000 (11:20 +0200)
commitdc6f55e9f8dac4b6479be67c5c9128ad37bb491f
tree1c2de6c93f84f7a93c35fc73d8ffec52f98ad117
parent940aab490215424a269f93d2eba2794fc8b3e269
NFS/sunrpc: don't use a credential with extra groups.

The sunrpc layer keeps a cache of recently used credentials and
'unx_match' is used to find the credential which matches the current
process.

However unx_match allows a match when the cached credential has extra
groups at the end of uc_gids list which are not in the process group list.

So if a process with a list of (say) 4 group accesses a file and gains
access because of the last group in the list, then another process
with the same uid and gid, and a gid list being the first tree of the
gids of the original process tries to access the file, it will be
granted access even though it shouldn't as the wrong rpc credential
will be used.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: stable@vger.kernel.org
net/sunrpc/auth_unix.c