]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
NFS: Sync the correct byte range during synchronous writes
authortarangg@amazon.com <tarangg@amazon.com>
Thu, 7 Sep 2017 13:29:23 +0000 (09:29 -0400)
committerSeth Forshee <seth.forshee@canonical.com>
Fri, 15 Sep 2017 16:15:45 +0000 (09:15 -0700)
commitdcc096f74fc39c1275268da598da31c7e59d2fdc
treedae8715a2aa0ea6316a4a3226415dde0529262ba
parent5b4dacb0f40d39950362a3ab2314ba0e7b3e4b4e
NFS: Sync the correct byte range during synchronous writes

BugLink: http://bugs.launchpad.net/bugs/1717549
commit e973b1a5999e57da677ab50da5f5479fdc0f0c31 upstream.

Since commit 18290650b1c8 ("NFS: Move buffered I/O locking into
nfs_file_write()") nfs_file_write() has not flushed the correct byte
range during synchronous writes.  generic_write_sync() expects that
iocb->ki_pos points to the right edge of the range rather than the
left edge.

To replicate the problem, open a file with O_DSYNC, have the client
write at increasing offsets, and then print the successful offsets.
Block port 2049 partway through that sequence, and observe that the
client application indicates successful writes in advance of what the
server received.

Fixes: 18290650b1c8 ("NFS: Move buffered I/O locking into nfs_file_write()")
Signed-off-by: Jacob Strauss <jsstraus@amazon.com>
Signed-off-by: Tarang Gupta <tarangg@amazon.com>
Tested-by: Tarang Gupta <tarangg@amazon.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
fs/nfs/file.c