]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
perf: Fix unexported generic perf_arch_fetch_caller_regs
authorFrederic Weisbecker <fweisbec@gmail.com>
Tue, 16 Mar 2010 00:05:02 +0000 (01:05 +0100)
committerIngo Molnar <mingo@elte.hu>
Wed, 17 Mar 2010 11:26:49 +0000 (12:26 +0100)
commitdcd5c1662db59a6b82942f47fb6ac9dd63f6d3dd
tree432f0d89d45fc62d666d46e591ffe109f111cb1e
parent9f591fd76afdc0e5192e9ed00a36f8efc0b4dfe6
perf: Fix unexported generic perf_arch_fetch_caller_regs

perf_arch_fetch_caller_regs() is exported for the overriden x86
version, but not for the generic weak version.

As a general rule, weak functions should not have their symbol
exported in the same file they are defined.

So let's export it on trace_event_perf.c as it is used by trace
events only.

This fixes:

ERROR: ".perf_arch_fetch_caller_regs" [fs/xfs/xfs.ko] undefined!
ERROR: ".perf_arch_fetch_caller_regs" [arch/powerpc/platforms/cell/spufs/spufs.ko] undefined!

-v2: And also only build it if trace events are enabled.
-v3: Fix changelog mistake

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1268697902-9518-1-git-send-regression-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/cpu/perf_event.c
kernel/perf_event.c
kernel/trace/trace_event_perf.c