]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
hwmon: (w83793) Fix NULL pointer dereference by removing unnecessary structure field
authorNadezda Lutovinova <lutovinova@ispras.ru>
Tue, 21 Sep 2021 15:51:53 +0000 (18:51 +0300)
committerGuenter Roeck <linux@roeck-us.net>
Sat, 2 Oct 2021 12:14:11 +0000 (05:14 -0700)
commitdd4d747ef05addab887dc8ff0d6ab9860bbcd783
tree95d49c4c5a72dd1612fce3c162e8e90a2937c0c8
parent0f36b88173f028e372668ae040ab1a496834d278
hwmon: (w83793) Fix NULL pointer dereference by removing unnecessary structure field

If driver read tmp value sufficient for
(tmp & 0x08) && (!(tmp & 0x80)) && ((tmp & 0x7) == ((tmp >> 4) & 0x7))
from device then Null pointer dereference occurs.
(It is possible if tmp = 0b0xyz1xyz, where same literals mean same numbers)
Also lm75[] does not serve a purpose anymore after switching to
devm_i2c_new_dummy_device() in w83791d_detect_subclients().

The patch fixes possible NULL pointer dereference by removing lm75[].

Found by Linux Driver Verification project (linuxtesting.org).

Cc: stable@vger.kernel.org
Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
Link: https://lore.kernel.org/r/20210921155153.28098-3-lutovinova@ispras.ru
[groeck: Dropped unnecessary continuation lines, fixed multi-line alignments]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/w83793.c