]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
net: fix socket refcounting in skb_complete_wifi_ack()
authorEric Dumazet <edumazet@google.com>
Sat, 4 Mar 2017 05:01:02 +0000 (21:01 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 7 Mar 2017 22:06:14 +0000 (14:06 -0800)
commitdd4f10722aeb10f4f582948839f066bebe44e5fb
tree208405a490829ceb4a413eb4f388a7185f675e35
parent146d8fef9da1ba854de7fa28b9cb9eb147535f88
net: fix socket refcounting in skb_complete_wifi_ack()

TX skbs do not necessarily hold a reference on skb->sk->sk_refcnt
By the time TX completion happens, sk_refcnt might be already 0.

sock_hold()/sock_put() would then corrupt critical state, like
sk_wmem_alloc.

Fixes: bf7fa551e0ce ("mac80211: Resolve sk_refcnt/sk_wmem_alloc issue in wifi ack path")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Soheil Hassas Yeganeh <soheil@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/skbuff.c