]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
igc: igc_write_phy_reg_gpy: drop premature return
authorSasha Neftin <sasha.neftin@intel.com>
Sun, 20 Feb 2022 07:29:15 +0000 (09:29 +0200)
committerPaolo Pisati <paolo.pisati@canonical.com>
Wed, 9 Mar 2022 14:17:55 +0000 (15:17 +0100)
commitdd60bdc7485fe6fcb59fa4184b91d736763c46df
treec4c6c59bd98c99611fe8e23f10364ab6a45f69c1
parent09862630ed68b2664097f9d1400bfe1738e5b622
igc: igc_write_phy_reg_gpy: drop premature return

BugLink: https://bugs.launchpad.net/bugs/1964361
commit c4208653a327a09da1e9e7b10299709b6d9b17bf upstream.

Similar to "igc_read_phy_reg_gpy: drop premature return" patch.
igc_write_phy_reg_gpy checks the return value from igc_write_phy_reg_mdic
and if it's not 0, returns immediately. By doing this, it leaves the HW
semaphore in the acquired state.

Drop this premature return statement, the function returns after
releasing the semaphore immediately anyway.

Fixes: 5586838fe9ce ("igc: Add code for PHY support")
Suggested-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
Reported-by: Corinna Vinschen <vinschen@redhat.com>
Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/net/ethernet/intel/igc/igc_phy.c