]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
vhost: return bool from *_access_ok() functions
authorStefan Hajnoczi <stefanha@redhat.com>
Wed, 11 Apr 2018 02:35:41 +0000 (10:35 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 Apr 2018 14:54:06 +0000 (10:54 -0400)
commitddd3d4081ffa806ffef28eaeefde757ba2b6812a
treee55d8ec43f5c5ce6d42a3af79d69361113819d7b
parentd14d2b78090c7de0557362b26a4ca591aa6a9faa
vhost: return bool from *_access_ok() functions

Currently vhost *_access_ok() functions return int.  This is error-prone
because there are two popular conventions:

1. 0 means failure, 1 means success
2. -errno means failure, 0 means success

Although vhost mostly uses #1, it does not do so consistently.
umem_access_ok() uses #2.

This patch changes the return type from int to bool so that false means
failure and true means success.  This eliminates a potential source of
errors.

Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/vhost/vhost.c
drivers/vhost/vhost.h