]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ibmvnic: don't spin in tasklet
authorSukadev Bhattiprolu <sukadev@linux.ibm.com>
Sat, 22 Jan 2022 02:59:20 +0000 (18:59 -0800)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 29 Mar 2022 07:13:49 +0000 (09:13 +0200)
commitde09c4f0f41808f5c468491a3c81660444485fcb
treee60ba7a95e86df5247e662fbac6e29f09e5e3426
parentf7eff1a8a99715516e4581cb30da19b6793c6989
ibmvnic: don't spin in tasklet

BugLink: https://bugs.launchpad.net/bugs/1962345
[ Upstream commit 48079e7fdd0269d66b1d7d66ae88bd03162464ad ]

ibmvnic_tasklet() continuously spins waiting for responses to all
capability requests. It does this to avoid encountering an error
during initialization of the vnic. However if there is a bug in the
VIOS and we do not receive a response to one or more queries the
tasklet ends up spinning continuously leading to hard lock ups.

If we fail to receive a message from the VIOS it is reasonable to
timeout the login attempt rather than spin indefinitely in the tasklet.

Fixes: 249168ad07cd ("ibmvnic: Make CRQ interrupt tasklet wait for all capabilities crqs")
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Reviewed-by: Dany Madden <drt@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/ethernet/ibm/ibmvnic.c