]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
block: Prevent hung_check firing during long sync IO
authorMing Lei <ming.lei@redhat.com>
Wed, 18 Mar 2020 03:43:36 +0000 (11:43 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 18 Mar 2020 14:48:03 +0000 (08:48 -0600)
commitde6a78b601c529398ad1448e3bffcade1fcf5a70
tree5568090a7bd5dedc3b76fd181bbd6fd99abff17d
parentd981cb5b9fa0da9da6a6c8b9ae7cbe789c3b3214
block: Prevent hung_check firing during long sync IO

submit_bio_wait() can be called from ioctl(BLKSECDISCARD), which
may take long time to complete, as Salman mentioned, 4K BLKSECDISCARD
takes up to 100 second on some devices. Also any block I/O operation
that occurs after the BLKSECDISCARD is submitted will also potentially
be affected by the hung task timeouts.

Another report is that task hang can be observed when running mkfs
over raid10 which takes a small max discard sectors limit because
of chunk size.

So prevent hung_check from firing by taking same approach used
in blk_execute_rq(), and the wake-up interval is set as half the
hung_check timer period, which keeps overhead low enough.

Cc: Salman Qazi <sqazi@google.com>
Cc: Jesse Barnes <jsbarnes@google.com>
Cc: Bart Van Assche <bvanassche@acm.org>
Link: https://lkml.org/lkml/2020/2/12/1193
Reported-by: Salman Qazi <sqazi@google.com>
Reviewed-by: Jesse Barnes <jsbarnes@google.com>
Reviewed-by: Salman Qazi <sqazi@google.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bio.c