]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/i915: Use crtc_state->active in primary check_plane func
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 7 Jul 2015 09:15:47 +0000 (11:15 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 8 Jul 2015 14:42:25 +0000 (16:42 +0200)
commitdec4f799d0a4c9edae20512fa60b0a36f3299ca2
treeb381e0bff423164138c673ec283f4737b3253f62
parent63fef06ada94172d7b4295fc205441bafd8f8fb3
drm/i915: Use crtc_state->active in primary check_plane func

Since

commit 8c7b5ccb729870e606321b3703e2c2e698c49a95
Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Date:   Tue Apr 21 17:13:19 2015 +0300

    drm/i915: Use atomic helpers for computing changed flags

we compute the plane state for a modeset before actually committing
any changes, which means crtc->active won't be correct yet. Looking at
future work in the modeset conversion targetting 4.3 the only places
where crtc_state->active isn't accurate is when disabling other CRTCs
than the one the modeset is for (when stealing connectors). Which
isn't the case here. And that's also confirmed by an audit, we do
unconditionally update crtc_state->active for the current pipe.

We also don't need to update any other plane check functions since we
only ever add the primary state to the modeset update right now.

Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c