]> git.proxmox.com Git - mirror_frr.git/commit
isisd: Fix handling of neighbor circuit id in three way handshake
authorChristian Franke <chris@opensourcerouting.org>
Mon, 30 Sep 2019 23:53:44 +0000 (01:53 +0200)
committerChristian Franke <chris@opensourcerouting.org>
Tue, 1 Oct 2019 10:12:22 +0000 (12:12 +0200)
commitdf04b6afc424f254d227bc42a78dbe658289f5a3
treecf752cef724ee908e116bfd52b9bdbc822fa9924
parent44cde8a39faac62c488368a9c352f9a40c8ea812
isisd: Fix handling of neighbor circuit id in three way handshake

RFC 5303 states:

      If the system ID and Extended Local Circuit ID of the neighboring
      system are known (in adjacency three-way state Initializing or
      Up), the neighbor's system ID SHALL be reported in the Neighbor
      System ID field, and the neighbor's Extended Local Circuit ID
      SHALL be reported in the Neighbor Extended Local Circuit ID field.

There is nothing written about only setting the Extended circuit ID of the
adjacency only when we bring the three-way adjacency up.

In fact, we should always update it, to avoid the problem described in #4783.

Fixes: #4783
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
isisd/isis_pdu.c