]> git.proxmox.com Git - mirror_qemu.git/commit
target/s390x: Fix cc_calc_sla_64() missing overflows
authorIlya Leoshkevich <iii@linux.ibm.com>
Wed, 12 Jan 2022 16:50:14 +0000 (17:50 +0100)
committerThomas Huth <thuth@redhat.com>
Mon, 17 Jan 2022 07:36:33 +0000 (08:36 +0100)
commitdf103c09bc2f549d36ba6313a69c18fc003ef1ee
tree2df4706ba21bf1d8b7117a62be6d1c7e1aad30ef
parent57556b28afde4b039bb12bfc274bd8df9022d946
target/s390x: Fix cc_calc_sla_64() missing overflows

An overflow occurs for SLAG when at least one shifted bit is not equal
to sign bit. Therefore, we need to check that `shift + 1` bits are
neither all 0s nor all 1s. The current code checks only `shift` bits,
missing some overflows.

Fixes: cbe24bfa91d2 ("target-s390: Convert SHIFT, ROTATE SINGLE")
Co-developed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20220112165016.226996-4-iii@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
target/s390x/tcg/cc_helper.c