]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
NFSD: enhance inter-server copy cleanup
authorDai Ngo <dai.ngo@oracle.com>
Mon, 19 Dec 2022 00:55:53 +0000 (16:55 -0800)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 20 Feb 2023 14:20:21 +0000 (09:20 -0500)
commitdf24ac7a2e3a9d0bc68f1756a880e50bfe4b4522
tree98c6c8af145b6b734fdd08731c7913b6084f8ed6
parentf4afc8fead386c81fda2593ad6162271d26667f8
NFSD: enhance inter-server copy cleanup

Currently nfsd4_setup_inter_ssc returns the vfsmount of the source
server's export when the mount completes. After the copy is done
nfsd4_cleanup_inter_ssc is called with the vfsmount of the source
server and it searches nfsd_ssc_mount_list for a matching entry
to do the clean up.

The problems with this approach are (1) the need to search the
nfsd_ssc_mount_list and (2) the code has to handle the case where
the matching entry is not found which looks ugly.

The enhancement is instead of nfsd4_setup_inter_ssc returning the
vfsmount, it returns the nfsd4_ssc_umount_item which has the
vfsmount embedded in it. When nfsd4_cleanup_inter_ssc is called
it's passed with the nfsd4_ssc_umount_item directly to do the
clean up so no searching is needed and there is no need to handle
the 'not found' case.

Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
[ cel: adjusted whitespace and variable/function names ]
Reviewed-by: Olga Kornievskaia <kolga@netapp.com>
fs/nfsd/nfs4proc.c
fs/nfsd/xdr4.h
include/linux/nfs_ssc.h