]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
dm integrity: fix memory corruption when tag_size is less than digest size
authorMikulas Patocka <mpatocka@redhat.com>
Sun, 3 Apr 2022 18:38:22 +0000 (14:38 -0400)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 12:42:38 +0000 (14:42 +0200)
commitdf4c405b282e4759db27958cebc4c045e05c8c6e
tree83fbe6ccf87a8875dd082eb86ef8464faaf439e9
parentad157d930fc3f285e1e792de59f5a46a60e3e23d
dm integrity: fix memory corruption when tag_size is less than digest size

BugLink: https://bugs.launchpad.net/bugs/1969857
commit 08c1af8f1c13bbf210f1760132f4df24d0ed46d6 upstream.

It is possible to set up dm-integrity in such a way that the
"tag_size" parameter is less than the actual digest size. In this
situation, a part of the digest beyond tag_size is ignored.

In this case, dm-integrity would write beyond the end of the
ic->recalc_tags array and corrupt memory. The corruption happened in
integrity_recalc->integrity_sector_checksum->crypto_shash_final.

Fix this corruption by increasing the tags array so that it has enough
padding at the end to accomodate the loop in integrity_recalc() being
able to write a full digest size for the last member of the tags
array.

Cc: stable@vger.kernel.org # v4.19+
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/md/dm-integrity.c