]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
ipv4: try to cache dst_entries which would cause a redirect
authorHannes Frederic Sowa <hannes@stressinduktion.org>
Fri, 23 Jan 2015 11:01:26 +0000 (12:01 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 27 Jan 2015 01:28:27 +0000 (17:28 -0800)
commitdf4d92549f23e1c037e83323aff58a21b3de7fe0
treecb82536dd48281496b6652b628266cdcacffb91d
parent412d2907c41531b60c7ea1f38cfe1116daf2a229
ipv4: try to cache dst_entries which would cause a redirect

Not caching dst_entries which cause redirects could be exploited by hosts
on the same subnet, causing a severe DoS attack. This effect aggravated
since commit f88649721268999 ("ipv4: fix dst race in sk_dst_get()").

Lookups causing redirects will be allocated with DST_NOCACHE set which
will force dst_release to free them via RCU.  Unfortunately waiting for
RCU grace period just takes too long, we can end up with >1M dst_entries
waiting to be released and the system will run OOM. rcuos threads cannot
catch up under high softirq load.

Attaching the flag to emit a redirect later on to the specific skb allows
us to cache those dst_entries thus reducing the pressure on allocation
and deallocation.

This issue was discovered by Marcelo Leitner.

Cc: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Marcelo Leitner <mleitner@redhat.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/ip.h
net/ipv4/ip_forward.c
net/ipv4/route.c