]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
ipv4: provide stronger user input validation in nl_fib_input()
authorEric Dumazet <edumazet@google.com>
Wed, 22 Mar 2017 02:22:28 +0000 (19:22 -0700)
committerTim Gardner <tim.gardner@canonical.com>
Thu, 30 Mar 2017 12:35:45 +0000 (06:35 -0600)
commitdf7bfb4ca4ee6cd5a4267e4f9a545eb24ee14dc1
tree73e7507e63971f7a555c8bfe7c2cc9072f8afed7
parent2edc14da3cf5df857ea233bf2a8dd505726f3ad1
ipv4: provide stronger user input validation in nl_fib_input()

BugLink: http://bugs.launchpad.net/bugs/1677589
[ Upstream commit c64c0b3cac4c5b8cb093727d2c19743ea3965c0b ]

Alexander reported a KMSAN splat caused by reads of uninitialized
field (tb_id_in) from user provided struct fib_result_nl

It turns out nl_fib_input() sanity tests on user input is a bit
wrong :

User can pretend nlh->nlmsg_len is big enough, but provide
at sendmsg() time a too small buffer.

Reported-by: Alexander Potapenko <glider@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
net/ipv4/fib_frontend.c