]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
drm/i915: Force a TypeC PHY disconnect during suspend/shutdown
authorImre Deak <imre.deak@intel.com>
Tue, 20 Jul 2021 13:24:49 +0000 (21:24 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 13 Aug 2021 07:31:52 +0000 (09:31 +0200)
commitdfa5de1b7b8a5c4a724696e19afb74ed2c9c696f
tree9624d42d0afb50c9d832aff82a1c436eab569bf6
parent433359302eaf160d5ddb1011a16be7ec94e0dac9
drm/i915: Force a TypeC PHY disconnect during suspend/shutdown

BugLink: https://bugs.launchpad.net/bugs/1931072
Disconnect TypeC PHYs during system suspend and shutdown, even with the
corresponding TypeC sink still plugged to its connector, since leaving
the PHY connected causes havoc at least during system resume in the
presence of an Nvidia card.

Note that this will only make a difference in the TypeC DP alternate
mode, since in Thunderbolt alternate mode the PHY is never owned by the
display engine and there is no notion of PHY ownership in legacy mode
(the display engine being the only possible owner in that mode and the
TypeC subsystem not having anything to do with the port in that case).

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3500
Reported-and-tested-by: Chris Chiu <chris.chiu@canonical.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210610174223.605904-1-imre.deak@intel.com
(backported from commit 151ec347b06a2fb6ecd2922475dca71a7af827a5
linux-next)
[Chris: drop function intel_ddi_is_tc() since it's used by different
ddi_{enable,disable}_clock() vfuncs which are not introduced yet]
Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/gpu/drm/i915/display/intel_ddi.c
drivers/gpu/drm/i915/display/intel_tc.c
drivers/gpu/drm/i915/display/intel_tc.h