]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
selinux: initialize proto variable in selinux_ip_postroute_compat()
authorTom Rix <trix@redhat.com>
Fri, 24 Dec 2021 15:07:39 +0000 (07:07 -0800)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 7 Mar 2022 15:34:40 +0000 (16:34 +0100)
commitdfde60fb94495a73af7183be01ea1d9261f76d2b
tree27259c5e5e1e77f3a97fe63b288a435dac154402
parentee2585d9e002fa411e7fbbb6ed1fed86b651a942
selinux: initialize proto variable in selinux_ip_postroute_compat()

BugLink: https://bugs.launchpad.net/bugs/1958898
commit 732bc2ff080c447f8524f40c970c481f5da6eed3 upstream.

Clang static analysis reports this warning

hooks.c:5765:6: warning: 4th function call argument is an uninitialized
                value
        if (selinux_xfrm_postroute_last(sksec->sid, skb, &ad, proto))
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

selinux_parse_skb() can return ok without setting proto.  The later call
to selinux_xfrm_postroute_last() does an early check of proto and can
return ok if the garbage proto value matches.  So initialize proto.

Cc: stable@vger.kernel.org
Fixes: eef9b41622f2 ("selinux: cleanup selinux_xfrm_sock_rcv_skb() and selinux_xfrm_postroute_last()")
Signed-off-by: Tom Rix <trix@redhat.com>
[PM: typo/spelling and checkpatch.pl description fixes]
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
security/selinux/hooks.c