]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
tty: fix compat TIOCGSERIAL checking wrong function ptr
authorEric Biggers <ebiggers@google.com>
Mon, 24 Feb 2020 18:20:44 +0000 (10:20 -0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 3 Apr 2020 13:17:23 +0000 (15:17 +0200)
commite02fab348275cbc3693960b5a222b6b34293cead
treea3b5c32247828a0011e5e1a72e9ca930935bc500
parent1e3f8e9197c538b0a9883315a6b2b21aa2232d87
tty: fix compat TIOCGSERIAL checking wrong function ptr

BugLink: https://bugs.launchpad.net/bugs/1869061
commit 6e622cd8bd888c7fa3ee2b7dfb3514ab53b21570 upstream.

Commit 77654350306a ("take compat TIOC[SG]SERIAL treatment into
tty_compat_ioctl()") changed the compat version of TIOCGSERIAL to start
checking for the presence of the ->set_serial function pointer rather
than ->get_serial.  This appears to be a copy-and-paste error, since
->get_serial is the function pointer that is called as well as the
pointer that is checked by the non-compat version of TIOCGSERIAL.

Fix this by checking the correct function pointer.

Fixes: 77654350306a ("take compat TIOC[SG]SERIAL treatment into tty_compat_ioctl()")
Cc: <stable@vger.kernel.org> # v4.20+
Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20200224182044.234553-3-ebiggers@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
drivers/tty/tty_io.c