]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
usb: ehci-orion: avoid double PHY initialization
authorMiquel Raynal <miquel.raynal@bootlin.com>
Tue, 29 Jan 2019 09:23:42 +0000 (10:23 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Jan 2019 08:22:35 +0000 (09:22 +0100)
commite04585184dcf792cd053d6ce84091201e45c2225
tree7b10ab2d6147151b6ecd460c6d9c48049e7459e9
parent12453a897e36665d75f1d7b722159ae1eeadf81c
usb: ehci-orion: avoid double PHY initialization

No need to initialize the PHY from the driver's probe. It is done by
the core automatically and doing it twice would increment the
phy->powercount counter to 2 instead of 1. During later suspend
operation, the counter will be decremented to one, no phy->power_off()
will occur and worse than that, the following phy->power_on() at
resume time will also be skipped, failing the whole S2RAM operation.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-orion.c