]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
mfd: intel_quark_i2c_gpio: Revert "Constify static struct resources"
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 2 Mar 2021 13:56:16 +0000 (15:56 +0200)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 8 Apr 2021 20:42:38 +0000 (15:42 -0500)
commite051f2aff8627f324194b96d785fa430503e4475
tree98c5780a06fe3782d4e68dd6962ea9cac199d5a4
parent85385b41c607751f43d40d10282e68783c6e3f61
mfd: intel_quark_i2c_gpio: Revert "Constify static struct resources"

BugLink: https://bugs.launchpad.net/bugs/1922601
[ Upstream commit a61f4661fba404418a7c77e86586dc52a58a93c6 ]

The structures are used as place holders, so they are modified at run-time.
Obviously they may not be constants.

  BUG: unable to handle page fault for address: d0643220
  ...
  CPU: 0 PID: 110 Comm: modprobe Not tainted 5.11.0+ #1
  Hardware name: Intel Corp. QUARK/GalileoGen2, BIOS 0x01000200 01/01/2014
  EIP: intel_quark_mfd_probe+0x93/0x1c0 [intel_quark_i2c_gpio]

This partially reverts the commit c4a164f41554d2899bed94bdcc499263f41787b4.

While at it, add a comment to avoid similar changes in the future.

Fixes: c4a164f41554 ("mfd: Constify static struct resources")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Tested-by: Tong Zhang <ztong0001@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/mfd/intel_quark_i2c_gpio.c