]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
BKL: Remove BKL from ext2 filesystem
authorJan Blunck <jblunck@suse.de>
Wed, 14 Apr 2010 12:38:39 +0000 (14:38 +0200)
committerJan Kara <jack@suse.cz>
Fri, 21 May 2010 17:30:40 +0000 (19:30 +0200)
commite0a5cbac029db69032758000c67465c2ed7a5736
tree14d81b8fee8d43674acd4c63a2e994bdc3da774c
parentc15271f4e74cd6dbdf461335d6d1450949c4b956
BKL: Remove BKL from ext2 filesystem

The BKL is still used in ext2_put_super(), ext2_fill_super(), ext2_sync_fs()
ext2_remount() and ext2_write_inode(). From these calls ext2_put_super(),
ext2_fill_super() and ext2_remount() are protected against each other by
the struct super_block s_umount rw semaphore. The call in ext2_write_inode()
could only protect the modification of the ext2_sb_info through
ext2_update_dynamic_rev() against concurrent ext2_sync_fs() or ext2_remount().
ext2_fill_super() and ext2_put_super() can be left out because you need a
valid filesystem reference in all three cases, which you do not have when
you are one of these functions.

If the BKL is only protecting the modification of the ext2_sb_info it can
safely be removed since this is protected by the struct ext2_sb_info s_lock.

Signed-off-by: Jan Blunck <jblunck@suse.de>
Cc: Jan Kara <jack@suse.cz>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/ext2/inode.c
fs/ext2/super.c