]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
virt: vbox: fix memory leak in hgcm_call_preprocess_linaddr
authorNavid Emamdoost <navid.emamdoost@gmail.com>
Mon, 30 Sep 2019 20:42:22 +0000 (15:42 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Oct 2019 12:50:32 +0000 (14:50 +0200)
commite0b0cb9388642c104838fac100a4af32745621e2
treef25a5186cb5d1fff89c24a9cc47e81a092a67f0d
parent5dc54a06f6e575f146492661129d24f3b50d17bb
virt: vbox: fix memory leak in hgcm_call_preprocess_linaddr

In hgcm_call_preprocess_linaddr memory is allocated for bounce_buf but
is not released if copy_form_user fails. In order to prevent memory leak
in case of failure, the assignment to bounce_buf_ret is moved before the
error check. This way the allocated bounce_buf will be released by the
caller.

Fixes: 579db9d45cb4 ("virt: Add vboxguest VMMDEV communication code")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20190930204223.3660-1-navid.emamdoost@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/virt/vboxguest/vboxguest_utils.c