]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
drm/stm: Use drm_fbdev_generic_setup()
authorNoralf Trønnes <noralf@tronnes.org>
Sat, 8 Sep 2018 13:46:42 +0000 (15:46 +0200)
committerNoralf Trønnes <noralf@tronnes.org>
Thu, 25 Oct 2018 15:00:28 +0000 (17:00 +0200)
commite0ce0e2a5df39065d2b8abefe7e2317e5996397d
treea9b4c73fddd56f7b36fb6b8eb276193dd23d5842
parentefbb9df91e03b31b00b0bce4147c135c15077a84
drm/stm: Use drm_fbdev_generic_setup()

The CMA helper is already using the drm_fb_helper_generic_probe part of
the generic fbdev emulation. This patch makes full use of the generic
fbdev emulation by using its drm_client callbacks. This means that
drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are
now handled by the emulation code. Additionally fbdev unregister happens
automatically on drm_dev_unregister().

The drm_fbdev_generic_setup() call is put after drm_dev_register() in the
driver. This is done to highlight the fact that fbdev emulation is an
internal client that makes use of the driver, it is not part of the
driver as such. If fbdev setup fails, an error is printed, but the driver
succeeds probing.

drm_fbdev_generic_setup() handles mode_config.num_connector being zero.
In that case it retries fbdev setup on the next .output_poll_changed.

Cc: Yannick Fertre <yannick.fertre@st.com>
Cc: Philippe Cornu <philippe.cornu@st.com>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Yannick Fertré <yannick.fertre@st.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180908134648.2582-15-noralf@tronnes.org
drivers/gpu/drm/stm/drv.c