]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
libertas: don't exit from lbs_ibss_join_existing() with RCU read lock held
authorNicolai Stange <nstange@suse.de>
Tue, 14 Jan 2020 10:39:02 +0000 (11:39 +0100)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 13 Mar 2020 04:31:00 +0000 (00:31 -0400)
commite12d32667d5e9bea2fcd52902f4b8d10c31148fa
tree32418b106b0f55e8408bb9a2a4753425ce0844ad
parentf380459c31eeb68191d4c2e11fcac8b1536d0e88
libertas: don't exit from lbs_ibss_join_existing() with RCU read lock held

BugLink: https://bugs.launchpad.net/bugs/1866678
[ Upstream commit c7bf1fb7ddca331780b9a733ae308737b39f1ad4 ]

Commit e5e884b42639 ("libertas: Fix two buffer overflows at parsing bss
descriptor") introduced a bounds check on the number of supplied rates to
lbs_ibss_join_existing().

Unfortunately, it introduced a return path from within a RCU read side
critical section without a corresponding rcu_read_unlock(). Fix this.

Fixes: e5e884b42639 ("libertas: Fix two buffer overflows at parsing bss descriptor")
Signed-off-by: Nicolai Stange <nstange@suse.de>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/net/wireless/marvell/libertas/cfg.c