]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
be2net: Fix invocation of be_close() after be_clear()
authorKalesh AP <kalesh.purayil@emulex.com>
Mon, 14 Apr 2014 10:42:41 +0000 (16:12 +0530)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Apr 2014 17:41:37 +0000 (13:41 -0400)
commite1ad8e33d2e57ca64d9862b63d986fc296a7b876
tree37889e4b5e71892beadcd3fcff25da9033d81c3a
parent1a3d0717f68345730ae939b74b952200fb165f45
be2net: Fix invocation of be_close() after be_clear()

In the EEH error recovery path, when a permanent failure occurs,
we clean up adapter structure (i.e. destroy queues etc) by calling
be_clear() and return PCI_ERS_RESULT_DISCONNECT.
After this the stack tries to remove device from bus and calls
be_remove() which invokes netdev_unregister()->be_close().
be_close() operating on destroyed queues results in a
NULL dereference.

This patch fixes this problem by introducing a flag to keep track
of the setup state.

Signed-off-by: Kalesh AP <kalesh.purayil@emulex.com>
Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/emulex/benet/be.h
drivers/net/ethernet/emulex/benet/be_main.c