]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
gpio: rcar: Improve clock error handling and reporting
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 4 Dec 2015 15:33:53 +0000 (16:33 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 11 Dec 2015 09:11:40 +0000 (10:11 +0100)
commite1fef9e2ce4272b720ecb1ce696a72aaddbb7585
tree7f0db2e1ff9ef4fac656f2fa0a89c3758cb4bb9e
parent8b092be9fd6a2cd84c437128e9b0d85e364efcfb
gpio: rcar: Improve clock error handling and reporting

If the Renesas R-Car GPIO driver cannot find a functional clock, it
prints a warning, .e.g.

gpio_rcar ffc40000.gpio: unable to get clock

and continues, as the clock is optional, depending on the SoC type.
This warning may confuse users.

To fix this, add a flag to indicate that the clock is mandatory or
optional:
  - If the clock is mandatory (on R-Car Gen2 and Gen3), a missing clock
    is now treated as a fatal error,
  - If the clock is optional (on R-Car Gen1), the warning is no longer
    printed.

Suggested-by: Magnus Damm <magnus.damm@gmail.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-rcar.c