]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
btrfs: tree-check: reduce stack consumption in check_dir_item
authorDavid Sterba <dsterba@suse.com>
Wed, 10 Jan 2018 14:13:07 +0000 (15:13 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 22 Jan 2018 15:08:21 +0000 (16:08 +0100)
commite2683fc9d219430f5b78889b50cde7f40efeba7b
treeb8de1fa06788f0154a84dbf919a5b3f7e8421fd5
parent6670d4c2d9b7d352cbf90cd18c516bb6444acf34
btrfs: tree-check: reduce stack consumption in check_dir_item

I've noticed that the updated item checker stack consumption increased
dramatically in 542f5385e20cf97447 ("btrfs: tree-checker: Add checker
for dir item")

tree-checker.c:check_leaf                    +552 (176 -> 728)

The array is 255 bytes long, dynamic allocation would slow down the
sanity checks so it's more reasonable to keep it on-stack. Moving the
variable to the scope of use reduces the stack usage again

tree-checker.c:check_leaf                    -264 (728 -> 464)

Reviewed-by: Josef Bacik <jbacik@fb.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/tree-checker.c