]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
umd: Transform fork_usermode_blob into fork_usermode_driver
authorEric W. Biederman <ebiederm@xmission.com>
Thu, 25 Jun 2020 18:12:59 +0000 (13:12 -0500)
committerEric W. Biederman <ebiederm@xmission.com>
Sat, 4 Jul 2020 14:35:29 +0000 (09:35 -0500)
commite2dc9bf3f5275ca372001541e5f26af572976e65
treec5ac5d724d6a9cd37714615ec860a8b639d9d9fd
parent1199c6c3da5197e9924a906b9de71b8d0ac62a01
umd: Transform fork_usermode_blob into fork_usermode_driver

Instead of loading a binary blob into a temporary file with
shmem_kernel_file_setup load a binary blob into a temporary tmpfs
filesystem.  This means that the blob can be stored in an init section
and discared, and it means the binary blob will have a filename so can
be executed normally.

The only tricky thing about this code is that in the helper function
blob_to_mnt __fput_sync is used.  That is because a file can not be
executed if it is still open for write, and the ordinary delayed close
for kernel threads does not happen soon enough, which causes the
following exec to fail.  The function umd_load_blob is not called with
any locks so this should be safe.

Executing the blob normally winds up correcting several problems with
the user mode driver code discovered by Tetsuo Handa[1].  By passing
an ordinary filename into the exec, it is no longer necessary to
figure out how to turn a O_RDWR file descriptor into a properly
referende counted O_EXEC file descriptor that forbids all writes.  For
path based LSMs there are no new special cases.

[1] https://lore.kernel.org/linux-fsdevel/2a8775b4-1dd5-9d5c-aa42-9872445e0942@i-love.sakura.ne.jp/
v1: https://lkml.kernel.org/r/87d05mf0j9.fsf_-_@x220.int.ebiederm.org
v2: https://lkml.kernel.org/r/87wo3p4p35.fsf_-_@x220.int.ebiederm.org
Link: https://lkml.kernel.org/r/20200702164140.4468-8-ebiederm@xmission.com
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Tested-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
include/linux/usermode_driver.h
kernel/usermode_driver.c
net/bpfilter/bpfilter_kern.c