]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
lpc_eth: add missing ndo_change_mtu()
authorEric Dumazet <edumazet@google.com>
Sun, 10 Jun 2012 23:24:00 +0000 (23:24 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 11 Jun 2012 20:12:26 +0000 (13:12 -0700)
commite30478598a8476d02e3b00caa89ce1a3b1dad54b
tree07344e1c01b5f42ec78fc62b49ca37b9052d1ce6
parented6be3dcfee0bb891efd6ea908ca32bea711085b
lpc_eth: add missing ndo_change_mtu()

lpc_eth does a copy of transmitted skbs to DMA area, without checking
skb lengths, so can trigger buffer overflows :

memcpy(pldat->tx_buff_v + txidx * ENET_MAXF_SIZE, skb->data, len);

One way to get bigger skbs is to allow MTU changes above the 1500 limit.

Calling eth_change_mtu() in ndo_change_mtu() makes sure this cannot
happen.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Roland Stigge <stigge@antcom.de>
Cc: Kevin Wells <kevin.wells@nxp.com>
Acked-by: Roland Stigge <stigge@antcom.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/nxp/lpc_eth.c