]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ftrace: Avoid potential division by zero in function profiler
authorWen Yang <wenyang@linux.alibaba.com>
Fri, 3 Jan 2020 03:02:48 +0000 (11:02 +0800)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Fri, 3 Jan 2020 03:14:57 +0000 (22:14 -0500)
commite31f7939c1c27faa5d0e3f14519eaf7c89e8a69d
tree7e57560cc349e3336dd9033726bc429f5ee4adae
parentb8299d362d0837ae39e87e9019ebe6b736e0f035
ftrace: Avoid potential division by zero in function profiler

The ftrace_profile->counter is unsigned long and
do_div truncates it to 32 bits, which means it can test
non-zero and be truncated to zero for division.
Fix this issue by using div64_ul() instead.

Link: http://lkml.kernel.org/r/20200103030248.14516-1-wenyang@linux.alibaba.com
Cc: stable@vger.kernel.org
Fixes: e330b3bcd8319 ("tracing: Show sample std dev in function profiling")
Fixes: 34886c8bc590f ("tracing: add average time in function to function profiler")
Signed-off-by: Wen Yang <wenyang@linux.alibaba.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/ftrace.c