]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
firmware: turris-mox-rwtm: fix reply status decoding function
authorMarek Behún <kabel@kernel.org>
Thu, 20 May 2021 11:35:17 +0000 (13:35 +0200)
committerGregory CLEMENT <gregory.clement@bootlin.com>
Thu, 17 Jun 2021 12:51:06 +0000 (14:51 +0200)
commite34e60253d9272311831daed8a2d967cf80ca3dc
tree1a7fbea6b9e273c2c2b4531e2482bac13a39141d
parent6efb943b8616ec53a5e444193dccf1af9ad627b5
firmware: turris-mox-rwtm: fix reply status decoding function

The status decoding function mox_get_status() currently contains an
incorrect check: if the error status is not MBOX_STS_SUCCESS, it always
returns -EIO, so the comparison to MBOX_STS_FAIL is never executed and
we don't get the actual error code sent by the firmware.

Fix this.

Signed-off-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Fixes: 389711b37493 ("firmware: Add Turris Mox rWTM firmware driver")
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
drivers/firmware/turris-mox-rwtm.c