]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
nohz: Fix local_timer_softirq_pending()
authorAnna-Maria Gleixner <anna-maria@linutronix.de>
Tue, 31 Jul 2018 16:13:58 +0000 (18:13 +0200)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:41:52 +0000 (19:41 -0600)
commite3b2324293a2348836dba1592c4d35c7ca3d6ed9
tree1139a8a81ffe2b9fd1b6d3d45d672e1f72876fa8
parent061f6ba2721f7d994919db19eb7ddf072efeded3
nohz: Fix local_timer_softirq_pending()

BugLink: https://bugs.launchpad.net/bugs/1835845
commit 80d20d35af1edd632a5e7a3b9c0ab7ceff92769e upstream.

local_timer_softirq_pending() checks whether the timer softirq is
pending with: local_softirq_pending() & TIMER_SOFTIRQ.

This is wrong because TIMER_SOFTIRQ is the softirq number and not a
bitmask. So the test checks for the wrong bit.

Use BIT(TIMER_SOFTIRQ) instead.

Fixes: 5d62c183f9e9 ("nohz: Prevent a timer interrupt storm in tick_nohz_stop_sched_tick()")
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Daniel Bristot de Oliveira <bristot@redhat.com>
Acked-by: Frederic Weisbecker <frederic@kernel.org>
Cc: bigeasy@linutronix.de
Cc: peterz@infradead.org
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20180731161358.29472-1-anna-maria@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
kernel/time/tick-sched.c