]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
ACPI / APEI: Don't wait to serialise with oops messages when panic()ing
authorJames Morse <james.morse@arm.com>
Tue, 29 Jan 2019 18:48:37 +0000 (18:48 +0000)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 28 Mar 2019 20:05:19 +0000 (15:05 -0500)
commite3cf84e1fddf710135ba706c9a8082d2e869c64e
treeb9a4971435737416f2b9d5ec4fe491660d6ec5c1
parent3c9ad56664daab9ec9ea63b9181315ddd2a41e38
ACPI / APEI: Don't wait to serialise with oops messages when panic()ing

BugLink: https://bugs.launchpad.net/bugs/1822005
oops_begin() exists to group printk() messages with the oops message
printed by die(). To reach this caller we know that platform firmware
took this error first, then notified the OS via NMI with a 'panic'
severity.

Don't wait for another CPU to release the die-lock before panic()ing,
our only goal is to print this fatal error and panic().

This code is always called in_nmi(), and since commit 42a0bb3f7138
("printk/nmi: generic solution for safe printk in NMI"), it has been
safe to call printk() from this context. Messages are batched in a
per-cpu buffer and printed via irq-work, or a call back from panic().

Link: https://patchwork.kernel.org/patch/10313555/
Acked-by: Borislav Petkov <bp@suse.de>
Signed-off-by: James Morse <james.morse@arm.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
(cherry picked from commit 78b0b690f6558ed788dccafa45965325dd11ba89)
Signed-off-by: dann frazier <dann.frazier@canonical.com>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/acpi/apei/ghes.c