]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
tipc: use the right skb in tipc_sk_fill_sock_diag()
authorCong Wang <xiyou.wangcong@gmail.com>
Sat, 7 Apr 2018 01:54:52 +0000 (18:54 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 8 Apr 2018 16:34:29 +0000 (12:34 -0400)
commite41f0548473eb7b6499bd8482474e30ae6d31220
tree4704a448a00e5ab58d5b5972a6a47629ea8df610
parent81e98370293afcb58340ce8bd71af7b97f925c26
tipc: use the right skb in tipc_sk_fill_sock_diag()

Commit 4b2e6877b879 ("tipc: Fix namespace violation in tipc_sk_fill_sock_diag")
tried to fix the crash but failed, the crash is still 100% reproducible
with it.

In tipc_sk_fill_sock_diag(), skb is the diag dump we are filling, it is not
correct to retrieve its NETLINK_CB(), instead, like other protocol diag,
we should use NETLINK_CB(cb->skb).sk here.

Reported-by: <syzbot+326e587eff1074657718@syzkaller.appspotmail.com>
Fixes: 4b2e6877b879 ("tipc: Fix namespace violation in tipc_sk_fill_sock_diag")
Fixes: c30b70deb5f4 (tipc: implement socket diagnostics for AF_TIPC)
Cc: GhantaKrishnamurthy MohanKrishna <mohan.krishna.ghanta.krishnamurthy@ericsson.com>
Cc: Jon Maloy <jon.maloy@ericsson.com>
Cc: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/diag.c
net/tipc/socket.c
net/tipc/socket.h