]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
i2c: designware: prevent signals from aborting I2C transfers
authorMika Westerberg <mika.westerberg@linux.intel.com>
Wed, 22 May 2013 10:03:11 +0000 (13:03 +0300)
committerWolfram Sang <wsa@the-dreams.de>
Wed, 12 Jun 2013 18:39:06 +0000 (20:39 +0200)
commite42dba569fceca5d59a88571370785e9ce9775b8
treea3a20a20e227af9ba26d8025de5b53608e24b0f0
parentdfda7d8f09323163cad26dd35fe6293b4f7cee85
i2c: designware: prevent signals from aborting I2C transfers

If a process receives signal while it is waiting for I2C transfer to
complete, an error is returned to the caller and the transfer is aborted.
This can cause the driver to fail subsequent transfers. Also according to
commit d295a86eab2 (i2c: mv64xxx: work around signals causing I2C
transactions to be aborted) I2C drivers aren't supposed to abort
transactions on signals.

To prevent this switch to use wait_for_completion_timeout() instead of
wait_for_completion_interruptible_timeout() in the designware I2C driver.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Christian Ruppert <christian.ruppert@abilis.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-designware-core.c