]> git.proxmox.com Git - qemu.git/commit
scsi-disk: no need to call scsi_req_data on a short read
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 3 Aug 2011 08:49:04 +0000 (10:49 +0200)
committerAnthony Liguori <aliguori@us.ibm.com>
Fri, 12 Aug 2011 13:27:00 +0000 (08:27 -0500)
commite44089c79da29ba026d0083e1428b4e82763eeab
tree9012a76cf759a5b265b913da410bb34d78c15ae8
parent4333979e3d8c129953bba36ed87ce543d33cbea1
scsi-disk: no need to call scsi_req_data on a short read

In fact, if the HBA's transfer_data callback goes on with scsi_req_continue
the request will be completed successfully instead of showing a failure.
It can even cause a segmentation fault.

An easy way to trigger it is "eject -f cd" during installation (during media
test if the installer does something like that).

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
hw/scsi-disk.c