]> git.proxmox.com Git - mirror_qemu.git/commit
block/export: fix vhost-user-blk export sector number calculation
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 23 Feb 2021 14:46:50 +0000 (14:46 +0000)
committerKevin Wolf <kwolf@redhat.com>
Mon, 8 Mar 2021 13:56:54 +0000 (14:56 +0100)
commite44362ce317bcc46d409ed6c4a5ed2b46804bcbf
treee5839964ad1d23459380d3a2a524c2970a9f8a60
parent524bac0744e5abf95856fb9e31c01fd2ef102188
block/export: fix vhost-user-blk export sector number calculation

The driver is supposed to honor the blk_size field but the protocol
still uses 512-byte sector numbers. It is incorrect to multiply
req->sector_num by blk_size.

VIRTIO 1.1 5.2.5 Device Initialization says:

  blk_size can be read to determine the optimal sector size for the
  driver to use. This does not affect the units used in the protocol
  (always 512 bytes), but awareness of the correct value can affect
  performance.

Fixes: 3578389bcf76c824a5d82e6586a6f0c71e56f2aa ("block/export: vhost-user block device backend server")
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20210223144653.811468-10-stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/export/vhost-user-blk-server.c