]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
drm/sun4i: Fix releasing node when enumerating enpoints
authorJernej Skrabec <jernej.skrabec@siol.net>
Mon, 25 Jun 2018 12:02:46 +0000 (14:02 +0200)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:51:00 +0000 (19:51 -0600)
commite46f9cd7ae6dde6beb108459c3aa9e38031cbf51
tree16c0e92608987f5561938b525de32e573154c4b5
parenta5c4e80f1773fba5c914c76adb8b966c38bca332
drm/sun4i: Fix releasing node when enumerating enpoints

BugLink: https://bugs.launchpad.net/bugs/1836287
[ Upstream commit 367c359aa8637b15ee8df6335c5a29b7623966ec ]

sun4i_drv_add_endpoints() has a memory leak since it uses of_node_put()
when remote is equal to NULL and does nothing when remote has a valid
pointer.

Invert the logic to fix memory leak.

Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180625120304.7543-7-jernej.skrabec@siol.net
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/gpu/drm/sun4i/sun4i_drv.c