]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
hugetlb: fix nr_pmds accounting with shared page tables
authorKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Fri, 24 Jun 2016 21:49:51 +0000 (14:49 -0700)
committerKamal Mostafa <kamal@canonical.com>
Thu, 15 Sep 2016 15:26:16 +0000 (08:26 -0700)
commite494f06e19dc91dd527e3669cfeb38f8c08ed646
tree61f3be1a732f6290db2c881772b09f683af46c0a
parent8f1d3b68ff08466f55c55e03f9aa4d989c515095
hugetlb: fix nr_pmds accounting with shared page tables

BugLink: http://bugs.launchpad.net/bugs/1621113
commit c17b1f42594eb71b8d3eb5a6dfc907a7eb88a51d upstream.

We account HugeTLB's shared page table to all processes who share it.
The accounting happens during huge_pmd_share().

If somebody populates pud entry under us, we should decrease pagetable's
refcount and decrease nr_pmds of the process.

By mistake, I increase nr_pmds again in this case.  :-/ It will lead to
"BUG: non-zero nr_pmds on freeing mm: 2" on process' exit.

Let's fix this by increasing nr_pmds only when we're sure that the page
table will be used.

Link: http://lkml.kernel.org/r/20160617122506.GC6534@node.shutemov.name
Fixes: dc6c9a35b66b ("mm: account pmd page tables to the process")
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reported-by: zhongjiang <zhongjiang@huawei.com>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
mm/hugetlb.c