]> git.proxmox.com Git - mirror_qemu.git/commit
virtio: always use handle_aio_output if registered
authorPaolo Bonzini <pbonzini@redhat.com>
Tue, 28 Feb 2017 13:21:32 +0000 (14:21 +0100)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 22 Mar 2017 15:56:00 +0000 (17:56 +0200)
commite49a6618400d11e51e30328dfe8d7cafce82d4bc
tree5bc98e6494a0f47695d8e9bf570673fd8aec02dc
parenta77690c41da67d85bab1e784a9f24f18bc63dbd9
virtio: always use handle_aio_output if registered

Commit ad07cd6 ("virtio-scsi: always use dataplane path if ioeventfd is
active", 2016-10-30) and 9ffe337 ("virtio-blk: always use dataplane
path if ioeventfd is active", 2016-10-30) broke the virtio 1.0
indirect access registers.

The indirect access registers bypass the ioeventfd, so that virtio-blk
and virtio-scsi now repeatedly try to initialize dataplane instead of
triggering the guest->host EventNotifier.  Detect the situation by
checking vq->handle_aio_output; if it is not NULL, trigger the
EventNotifier, which is how the device expects to get notifications
and in fact the only thread-safe manner to deliver them.

Fixes: ad07cd6
Fixes: 9ffe337
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/virtio/virtio.c