]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
net: stmmac: dwc-qos: Disable split header for Tegra194
authorJon Hunter <jonathanh@nvidia.com>
Wed, 6 Jul 2022 08:39:13 +0000 (09:39 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 16 Sep 2022 08:52:44 +0000 (10:52 +0200)
commite4cfe3760b6765ca6a500099312d826fe9578729
treed12ec67b96d935ef13602760dde95722add02992
parentc8f4db371425f78f30819d7e03accbe977709783
net: stmmac: dwc-qos: Disable split header for Tegra194

BugLink: https://bugs.launchpad.net/bugs/1988351
[ Upstream commit 029c1c2059e9c4b38f97a06204cdecd10cfbeb8a ]

There is a long-standing issue with the Synopsys DWC Ethernet driver
for Tegra194 where random system crashes have been observed [0]. The
problem occurs when the split header feature is enabled in the stmmac
driver. In the bad case, a larger than expected buffer length is
received and causes the calculation of the total buffer length to
overflow. This results in a very large buffer length that causes the
kernel to crash. Why this larger buffer length is received is not clear,
however, the feedback from the NVIDIA design team is that the split
header feature is not supported for Tegra194. Therefore, disable split
header support for Tegra194 to prevent these random crashes from
occurring.

[0] https://lore.kernel.org/linux-tegra/b0b17697-f23e-8fa5-3757-604a86f3a095@nvidia.com/

Fixes: 67afd6d1cfdf ("net: stmmac: Add Split Header support and enable it in XGMAC cores")
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Link: https://lore.kernel.org/r/20220706083913.13750-1-jonathanh@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c