]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
btrfs: remove redundant time check in transaction kthread loop
authorNikolay Borisov <nborisov@suse.com>
Thu, 8 Oct 2020 12:24:28 +0000 (15:24 +0300)
committerDavid Sterba <dsterba@suse.com>
Tue, 8 Dec 2020 14:53:19 +0000 (15:53 +0100)
commite4e428816192798c2fa473ff67d9032b94f93291
tree34e1545005c8f4c23a8eba409880715b80c7d1aa
parentba1bc00f358190ae1011eae82766aba5c73c9ca2
btrfs: remove redundant time check in transaction kthread loop

The value obtained from ktime_get_seconds() is guaranteed to be
monotonically increasing since it's taken from CLOCK_MONOTONIC. As
transaction_kthread obtains a reference to the currently running
transaction under holding btrfs_fs_info::trans_lock it's guaranteed to:

a) see an initialized 'cur', whose start_time is guaranteed to be smaller
   than 'now'

or

b) not obtain a 'cur' and simply go to sleep.

Given this remove the unnecessary check, if it sees
now < cur->start_time this would imply there are far greater problems on
the machine.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/disk-io.c