]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
net/rds: Fix a use after free in rds_message_map_pages
authorLv Yunlong <lyl2019@mail.ustc.edu.cn>
Wed, 31 Mar 2021 01:59:59 +0000 (18:59 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 7 May 2021 07:53:37 +0000 (09:53 +0200)
commite52b6f29b2c289e1f69396bf9eac8c535b2ca14b
tree827ec0b580442888d9453fbd0a2c9d9ed0e05751
parentf6916dbb5f11ac69757251af36e074ae727a09d7
net/rds: Fix a use after free in rds_message_map_pages

BugLink: https://bugs.launchpad.net/bugs/1926368
[ Upstream commit bdc2ab5c61a5c07388f4820ff21e787b4dfd1ced ]

In rds_message_map_pages, the rm is freed by rds_message_put(rm).
But rm is still used by rm->data.op_sg in return value.

My patch assigns ERR_CAST(rm->data.op_sg) to err before the rm is
freed to avoid the uaf.

Fixes: 7dba92037baf3 ("net/rds: Use ERR_PTR for rds_message_alloc_sgs()")
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Reviewed-by: HÃ¥kon Bugge <haakon.bugge@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
net/rds/message.c